draft: jail_unix: Simplify sub-argument matching #4202
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: find a name and a home for the ARG_MATCH() macro. Refs 4001ea2 Refs varnishcache#4174
Taking inspiration from other languages with a match keyword, replace the if statement altogether by a pseudo-match statement that populates a destination variable similar to what FOREACH macros do.
|
Needs more work. I dont like that the strings become unquoted. Also: strlen() on constant strings is free with all compilers in recent memory. |
|
Requiring an actual quoted string is trivial, but before I proceed, where should this macro live and how should it be named? |
|
Flexelint has comments: name: I do not have any better idea place: next to ARGV_ERR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: find a name and a home for the ARG_MATCH() macro.
Refs 4001ea2
Refs #4174