Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify supported languages in an environment variable during build #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Kishore96in
Copy link

Resolves issue #15. I have not tried to autodetect the supported languages, since this seems to be much simpler, and is something that will only be done rarely.

Call cmake like
cmake -DVARNAM_LANGUAGES="ta;ml;hi;ml-inscript"
…directory."

This reverts commit 5e723a9.
I've put this fix in a separate branch, since it is in-principle
unrelated to the current issue.
@Kishore96in
Copy link
Author

@navaneeth Sorry for pinging you, but this pull request has been sitting for a while, and I was wondering if you think this is the wrong approach. The other approach I could imagine would be to write a script just to detect the languages (probably similar to https://github.com/varnamproject/libvarnam/blob/master/varnamc), which is then called from engine/CMakeLists.txt during the build process, but that seems like overkill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant