remove deprecated io/ioutil #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anoop142
commented
Nov 6, 2023
anoop142
commented
- ioutil is deprecated since go 1.16
- go version in go.mod is 1.16, so removing won't affect us
* ioutil is deprecated since go 1.16 * go version in go.mod is 1.16, so removing won't affect us
subins2000
reviewed
Nov 9, 2023
There was a problem hiding this comment.
@anoop142 Please see the build failures that happened after this change: https://github.com/varnamproject/govarnam/actions/runs/6814023334/job/18529920081
| @@ -377,7 +376,7 @@ func TestMLExportAndImport(t *testing.T) { | |||
| varnam.Export(exportFileIntendedPath, 300) | |||
|
|
|||
| // read the whole file at once | |||
| b, err := ioutil.ReadFile(exportFilePath) | |||
| b, err := os.ReadFile(exportFilePath) | |||
There was a problem hiding this comment.
This file misses the import of "os"
| @@ -1,7 +1,6 @@ | |||
| package govarnamgo | |||
|
|
|||
| import ( | |||
| "io/ioutil" | |||
| "log" | |||
| "os" | |||
| "os/exec" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.