Limit exported symbols #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge of MR dropped `else` which made the soname setting ineffective on Linux.
This greatly reduces the number of exported symbols by limiting the
namespace of exported symbols to {varnam,varray,vm}_ thus avoiding the
export of all the `_cg` symbols from go.
Before:
$ readelf -s /tmp/a/usr/lib/libgovarnam.so.1.9.0 | grep -v " UND " | wc -l
248
After:
$ readelf -s /usr/lib/libgovarnam.so.1.9.0 | grep -v " UND " | wc -l
52
With this we can make sure applications don't link against accidentally
exported symbols and break on library upgrades without us being able to
notice. It also allows us to notice when symbols go missing and we hence
need to bump the ABI version.
|
Thanks for merging this in so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly reduces the number of exported symbols by limiting the namespace of exported symbols to {varnam,varray,vm}_ thus avoiding the export of all the
_cgsymbols from go.Before:
After:
With this we can make sure applications don't link against accidentally exported symbols and break on library upgrades without us being able to notice. It also allows us to notice when symbols go missing and we hence need to bump the ABI version.
I've put this on top of #34
This also allows us to use symbol versioning for new symbols if desired.