build: Set a soname on the library #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current sed expression matches on all paths elements so if one has it's development e.g. in /var/scratch/librem5/ it would truncate the patch to /var/scratchrem5/ which then fails the build. Fix that by only matching at the end of paths to remove /lib from the libdir.
This sets an soname for dynamic linking: $ readelf -a libgovarnam.so | grep SONAME 0x000000000000000e (SONAME) Library soname: [libgovarnam.so.1] This is needed for ABI versioning and dynamlic linking. See e.g. Section 8.1 of Debian's policy. With this one gets properly versioned dependencies e.g. $ readelf -a _build/src/phosh-osk-stub | grep gov 0x0000000000000001 (NEEDED) Shared library: [libgovarnam.so.1.9.0] While without that patch one gets an unversioned dependency which won't allow to handle any ABI changes: $ readelf -a _build/src/phosh-osk-stub | grep libgovarn 0x0000000000000001 (NEEDED) Shared library: [/usr/local/lib/libgovarnam.so]
|
Thank you for the patches @agx ! Very helpful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets an soname for dynamic linking:
This is needed for ABI versioning and dynamlic linking. See e.g.
Section 8.1 of Debian's policy.
With this one gets properly versioned dependencies e.g.
While without that patch one gets an unversioned dependency which won't
allow to handle any ABI changes:
This includes the changes from #31 as otherwise there will be merge conflicts.