Split up useFilteredConsultants to smaller hooks #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sigrid Elnan <[email protected]>
sigridge
reviewed
Nov 9, 2023
|
|
||
| return ( | ||
| <div className="flex flex-row gap-1"> | ||
| <SecondaryButton label={"Denne uka"} onClick={resetSelectedWeek} /> | ||
| <IconSecondaryButton | ||
| icon={<ArrowLeft size={24} />} | ||
| onClick={decrementSelectedWeek} | ||
| onClick={() => changeSelectedWeek(-7)} |
There was a problem hiding this comment.
As the number of weeks changed is based on number of weeks shown, this needs to use -7, -11 or -23. Same with the function below 😅
There was a problem hiding this comment.
Good catch! 🎉 This will be changed based on the new weekSpan variable coming with the PR from @mathildehaugum :)
sigridge
reviewed
Nov 9, 2023
| } | ||
|
|
||
| function incrementSelectedWeek() { | ||
| changeSelectedWeek(6); |
There was a problem hiding this comment.
Should this use weekSpan - 1? 😄
There was a problem hiding this comment.
Nice catch. Is fixed now.
sigridge
approved these changes
Nov 9, 2023
| const { numWeeks = weekSpan } = updateParams; | ||
| const { availability = availabilityFilter } = updateParams; | ||
|
|
||
| console.log("Update route with numWeeks = " + numWeeks); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically refactor the useFilteredConsultants into separate hook.
NB: This is an initial refactor, and will improve further.