make staffing go swoosh #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigridge
reviewed
Nov 6, 2023
| @@ -31,6 +32,8 @@ public ConsultantController(ApplicationContext context, IMemoryCache cache) | |||
| [FromQuery(Name = "weeks")] int numberOfWeeks = 8, | |||
| [FromQuery(Name = "includeOccupied")] bool includeOccupied = true) | |||
| { | |||
| var watch = Stopwatch.StartNew(); | |||
There was a problem hiding this comment.
Husk å fjern denne før vi merger
trulshj
reviewed
Nov 6, 2023
| } | ||
|
|
||
|
|
||
| private List<ConsultantReadModel> GetConsultantsWithAvailability(string orgUrlKey, Week initialWeekNumber, | ||
| int numberOfWeeks) | ||
| { | ||
| if (numberOfWeeks == 8) | ||
| if (numberOfWeeks == 8 && false) |
There was a problem hiding this comment.
Suggested change
| if (numberOfWeeks == 8 && false) | |
| if (CacheEnabled && numberOfWeeks == 8) |
There was a problem hiding this comment.
Ups, denne skal helt vekk. Dette var bare for å tvinge vekk bruken av cache for å sammenligne kjøretiden mellom gammel og ny måte
|
Har oppdatert litt lesbarhet nå. Det blir være helt likt logisk sett, men den bør testes før merge |
sigridge
reviewed
Nov 7, 2023
| var consultants = GetConsultantsWithAvailability(orgUrlKey, selectedWeek, numberOfWeeks) | ||
| var weekSet = DateService.GetNextWeeks(selectedWeek, numberOfWeeks); | ||
|
|
||
| var consultants = GetConsultantReadModels(orgUrlKey, weekSet) | ||
| .Where(c => | ||
| includeOccupied | ||
| || c.IsOccupied |
There was a problem hiding this comment.
Dette har ingen ting med denne PR-en å gjøre egentlig, men skal det ikke være includeOccupied || !c.IsOccupied? For nå får man enten alle, eller kun de som er opptatt 🤔
sigridge
approved these changes
Nov 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Det funker nå, men har riktig nok mye forbedringspotensiale når det kommer til lesbarhet og lett-å-jobbe-med het.
Jeg kommer nok til å jobbe litt videre med dette så vi får kode som er enklere å jobbe med fremover også. Der er noen røde flagg/vonde lukter i koden, blant annet funksjonen "DetailedBooking" som tar inn 7 (!) parametre, og flere av disse er veldig veldig spesialiserte.
Videre kan også Consultants og Projects caches, som reduserer mengen DB-kall ytterligere.