Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dot to current week #245

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add dot to current week #245

merged 2 commits into from
Nov 2, 2023

Conversation

sigridge
Copy link
Contributor

@sigridge sigridge commented Nov 2, 2023

No description provided.

<p className="body-bold text-right">{b.weekNumber}</p>
</div>
) : (
<p className="body text-right">{b.weekNumber}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Litt usikker på om vi heller skulle hatt booking istedenfor b? Fordelen med b er at det blir kortere kode, mens booking gir litt mer lesbar kode, hva tenker du? 😄

Copy link
Contributor

@mathildehaugum mathildehaugum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig fin kode du har skrevet her! 🤩 God navngivning av funksjoner og variabler så det blir lettleselig kode. Det er en kommentar som egentlig gjelder for kode som ble skrevet før denne PR-en som du kan ta en titt på 👍 ellers godkjent for merge!

@sigridge sigridge merged commit e76126f into main Nov 2, 2023
3 checks passed
@sigridge sigridge deleted the show-current-week branch November 2, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants