236 select week #244
Merged
236 select week #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigridge
reviewed
Nov 1, 2023
|
|
||
| function handleNextWeekClick() { | ||
| if (selectedWeek) { | ||
| setSelectedWeek({ year: 2023, weekNumber: selectedWeek.weekNumber + 1 }); |
There was a problem hiding this comment.
Denne vil vel ikke ta hensyn til årskifte? 🤔
sigridge
approved these changes
Nov 2, 2023
| export function stringToWeek(urlString?: string): Week | undefined { | ||
| if (!urlString) return; | ||
| try { | ||
| const args = urlString.split("-"); |
There was a problem hiding this comment.
Kan du kanskje bruke destrukturering her for å gjøre koden lettere å lese? Eks:
const [yearStr, weekStr] = urlString.split("-");
const year = Number.parseInt(yearStr);
const week = Number.parseInt(weekStr);
| @@ -0,0 +1,22 @@ | |||
| import { Week } from "@/types"; | |||
There was a problem hiding this comment.
Litt usikker på å plassere denne filen i data-mappen. Forstår ulempen med en utils-mappe, men jeg tenker personlig det hadde vært enklere å lokalisere denne filen i en mappe som heter utils enn en som heter data 😅 Hva tenker dere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds possibility to change active week.
Note that this does not show which week is the current one.