Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📱 Scale font sizes to device #973

Merged
merged 4 commits into from
Dec 10, 2024
Merged

📱 Scale font sizes to device #973

merged 4 commits into from
Dec 10, 2024

Conversation

petterhh
Copy link
Contributor

@petterhh petterhh commented Dec 9, 2024

  • 📱 Scale font sizes to device
  • 🔥 Remove unused styles labelSmall and desktopLinkBig

Reviewer instructions

You are very welcome to go through the variables in Figma and verify that these styles actually correspond to the ones in Figma (please do 🙏 🙏 )

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 8:38am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 8:38am

Copy link
Member

@mikaelbr mikaelbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested preview now on different sizes and didn't find any issues (yet)

@petterhh petterhh linked an issue Dec 10, 2024 that may be closed by this pull request
petterhh and others added 3 commits December 10, 2024 08:25
🔥 Remove unused labelSmall
Co-authored-by: Mikael Brevik <[email protected]>
@petterhh petterhh merged commit c3fa6c1 into v3 Dec 10, 2024
6 checks passed
@petterhh petterhh deleted the v3-petterhh/scale-text-device branch December 10, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix responsive size for text
3 participants