-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📱 Scale font sizes to device #973
Merged
Merged
+60
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
petterhh
force-pushed
the
v3-petterhh/scale-text-device
branch
from
December 9, 2024 12:57
57a496d
to
f0e0f60
Compare
petterhh
force-pushed
the
v3-petterhh/scale-text-device
branch
from
December 9, 2024 14:21
e0d9024
to
0f657c8
Compare
petterhh
force-pushed
the
v3-petterhh/scale-text-device
branch
from
December 9, 2024 14:24
0f657c8
to
c0b564f
Compare
petterhh
force-pushed
the
v3-petterhh/scale-text-device
branch
from
December 9, 2024 14:27
c0b564f
to
63ae2a7
Compare
mikaelbr
reviewed
Dec 9, 2024
mikaelbr
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested preview now on different sizes and didn't find any issues (yet)
🔥 Remove unused labelSmall
Co-authored-by: Mikael Brevik <[email protected]>
petterhh
force-pushed
the
v3-petterhh/scale-text-device
branch
from
December 10, 2024 07:25
a4ade1c
to
f95fa5e
Compare
anemne
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labelSmall
anddesktopLinkBig
Reviewer instructions
You are very welcome to go through the variables in Figma and verify that these styles actually correspond to the ones in Figma (please do 🙏 🙏 )