-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds sanity structure for compensation calculator section #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
mikaelbr
force-pushed
the
mikael/v3-adds-calculator-module
branch
from
December 2, 2024 19:14
8fdb787
to
8f98dbf
Compare
mikaelbr
force-pushed
the
mikael/v3-adds-calculator-module
branch
from
December 3, 2024 15:57
79d0c05
to
967529e
Compare
mikaelbr
force-pushed
the
mikael/v3-adds-calculator-module
branch
from
December 6, 2024 06:58
9870a71
to
55fa9d8
Compare
mikaelbr
force-pushed
the
mikael/v3-adds-calculator-module
branch
from
December 6, 2024 07:01
55fa9d8
to
bd53b7b
Compare
anemne
reviewed
Dec 6, 2024
anemne
reviewed
Dec 6, 2024
anemne
reviewed
Dec 6, 2024
src/components/sections/compensation-calculator/CompensationCalculator.tsx
Outdated
Show resolved
Hide resolved
anemne
reviewed
Dec 6, 2024
Co-authored-by: anemne <[email protected]>
mikaelbr
force-pushed
the
mikael/v3-adds-calculator-module
branch
from
December 6, 2024 10:06
c582910
to
3a6e5e7
Compare
Co-authored-by: anemne <[email protected]>
petterhh
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Veery minor!
Co-authored-by: Petter Hohle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #896
Adds component for showing calculator based on numbers saved in compensation special page. Also extends the compensation special page to have handbook links to be used in the handbook block. This is stored centralised in the compensation page to easier reuse the component a cross different pages without having to add several things manually.
Todo
Things to follow-up later
Screen shots