Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds sanity structure for compensation calculator section #929

Merged
merged 18 commits into from
Dec 6, 2024

Conversation

mikaelbr
Copy link
Member

@mikaelbr mikaelbr commented Dec 1, 2024

Fixes #896

Adds component for showing calculator based on numbers saved in compensation special page. Also extends the compensation special page to have handbook links to be used in the handbook block. This is stored centralised in the compensation page to easier reuse the component a cross different pages without having to add several things manually.

Todo

  • Add translations
  • Set default year
  • Self-review and see if there are changes I need to do

Things to follow-up later

  • Heading sizes is off (generally)
  • Button is wrong (component needs to be updated)
  • Haven't added the chevrons but utilising default browser behaviour for number. This can be added in separate PR
Screen shots

Screenshot 2024-12-05 at 16 26 05 Screenshot 2024-12-05 at 16 23 43 Screenshot 2024-12-05 at 16 24 53

Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 11:40am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 11:40am

@mikaelbr mikaelbr linked an issue Dec 2, 2024 that may be closed by this pull request
@mikaelbr mikaelbr force-pushed the mikael/v3-adds-calculator-module branch from 8fdb787 to 8f98dbf Compare December 2, 2024 19:14
@mikaelbr mikaelbr force-pushed the mikael/v3-adds-calculator-module branch from 79d0c05 to 967529e Compare December 3, 2024 15:57
@petterhh petterhh mentioned this pull request Dec 5, 2024
3 tasks
@mikaelbr mikaelbr force-pushed the mikael/v3-adds-calculator-module branch from 9870a71 to 55fa9d8 Compare December 6, 2024 06:58
@mikaelbr mikaelbr force-pushed the mikael/v3-adds-calculator-module branch from 55fa9d8 to bd53b7b Compare December 6, 2024 07:01
Copy link
Contributor

@petterhh petterhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veery minor!

studio/schemas/objects/sections/compensation-calculator.ts Outdated Show resolved Hide resolved
@mikaelbr mikaelbr merged commit ea59917 into v3 Dec 6, 2024
5 of 6 checks passed
@mikaelbr mikaelbr deleted the mikael/v3-adds-calculator-module branch December 6, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modul ansattopplevelse
3 participants