Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds limit to number of employees to show #927

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

mikaelbr
Copy link
Member

Fixes #824

I set the text to as "show all" not "show more" as it actually shows all.

In a later PR

We don't have a proper Button / LinkButton component that matches the design.

Search isn't handled here.

Screenshots

Screenshot 2024-11-29 at 20 29 22
Screenshot 2024-11-29 at 20 29 16

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:37am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:37am

Copy link
Contributor

@idamand idamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@mikaelbr mikaelbr force-pushed the mikael/v3-limit-userfold branch from 9372b98 to 2424a24 Compare December 2, 2024 11:34
@mikaelbr mikaelbr merged commit 2287cea into v3 Dec 2, 2024
6 checks passed
@mikaelbr mikaelbr deleted the mikael/v3-limit-userfold branch December 2, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse employee section
2 participants