Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds split image component and add it to Employee site #926

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

mikaelbr
Copy link
Member

@mikaelbr mikaelbr commented Nov 29, 2024

Adds generic split image module that should work like this:
Can be used on several places, but adds this specific block to employee site.

Fixes #897

Todo later:

  • Fix ButtonLink component to match design

Screenshots:

Screenshot 2024-11-29 at 19 18 27
Screenshot 2024-11-29 at 19 18 07
Screenshot 2024-11-29 at 19 20 04

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:35pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:35pm


return (
<article className={styles.imageSplit}>
{showImageToLeft && (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do this css only with order to avoid having image be fore the title in the actual DOM, but would require not to use grid and I used grid to more robustly get it as 50/50 size. 🤔 Might be lazy

@mikaelbr
Copy link
Member Author

mikaelbr commented Dec 2, 2024

Legg til secondary link

Screenshot 2024-12-02 at 09 59 28

Copy link
Contributor

@idamand idamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@mikaelbr mikaelbr merged commit fe6fc55 into v3 Dec 2, 2024
6 checks passed
@mikaelbr mikaelbr deleted the mikael/v3-splitimage branch December 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seksjon "Bli en variant"
2 participants