feat: Color Picker for Customer Cases #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
idamand
reviewed
Nov 27, 2024
| @@ -39,7 +39,34 @@ const customerCase = defineType({ | |||
| type: "internationalizedArrayString", | |||
| title: "Title", | |||
| }), | |||
| defineField({ | |||
There was a problem hiding this comment.
According to the design the colors for the title and badge should be the same, is there any way to validate this or should we add that in the description?
There was a problem hiding this comment.
Or could we use one color picker for the "main" color, and another for the text? 🤔
There was a problem hiding this comment.
If they should always be the same, then we should only have one field for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit cursed, but this allows you to choose a subsection of the title to apply color to
TODO: Validation that the title actually contains the subsection you input
Fancy Color Picker Components!
Possible TODO: Show a preview of title / Badges
How these colors look applied: