Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 refactor project info #909

Merged
merged 5 commits into from
Nov 26, 2024
Merged

V3 refactor project info #909

merged 5 commits into from
Nov 26, 2024

Conversation

idamand
Copy link
Contributor

@idamand idamand commented Nov 26, 2024

This PR redesigns and refactors the project info section in customer case:

  • Make the badge component to be used in customer sectors for project info, and make it custom by allowing backgroundColor and textColor to be sent in as props, default is grey (preparation for a later PR where the user defines the color of the badges in Sanity)
  • Refactor project info into its own component to clean up the CustomerCase component
  • Redesign the CustomLink to match the design by adding new arrows to match internal vs. external links, and fixing the underline and font size
  • And other minor styling changes to project info so it matches the design, including mobile version
Screenshot 2024-11-26 at 12 33 24 Screenshot 2024-11-26 at 12 33 37 Screenshot 2024-11-26 at 12 33 50 Screenshot 2024-11-26 at 12 34 32

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:36am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:36am

trulshj
trulshj approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@trulshj trulshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/components/badge/Badge.tsx
Comment on lines +13 to +14
badgeColor = "#EAEAEA",
textColor = "#222424",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIGG!

@idamand idamand merged commit 40f6166 into v3 Nov 26, 2024
6 checks passed
@idamand idamand deleted the v3-refactor-project-info branch November 26, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trulshj trulshj trulshj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idamand @trulshj