Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3-breadcrumb-menu #838

Merged
merged 17 commits into from
Oct 30, 2024
Merged

V3-breadcrumb-menu #838

merged 17 commits into from
Oct 30, 2024

Conversation

anemne
Copy link
Contributor

@anemne anemne commented Oct 30, 2024

This PR adds a breadcrumb menu to the header.

Screenshot 2024-10-30 at 08 18 44

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:03pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:03pm

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

src/components/navigation/header/Header.tsx Show resolved Hide resolved
@mathiazom
Copy link
Contributor

Ideally, the breadcrumb titles would be based on the page titles from Sanity, not just the uppercased slugs. However, that might be quite complex, so this is probably a good initial version 👍

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

src/components/navigation/header/Header.tsx Show resolved Hide resolved
@mathiazom
Copy link
Contributor

Ideally, the breadcrumb titles would be based on the page titles from Sanity, not just the uppercased slugs. However, that might be quite complex, so this is probably a good initial version 👍

Defined an issue for this: #842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants