Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 - employee page #833

Merged
merged 3 commits into from
Oct 30, 2024
Merged

v3 - employee page #833

merged 3 commits into from
Oct 30, 2024

Conversation

mathiazom
Copy link
Contributor

@mathiazom mathiazom commented Oct 28, 2024 •
edited
Loading

See #832

Added very basic "mini-CV" subpage for employees.

  • defined Employees Page field in Navigation Manager to define the parent page. This is used to define the slug to be used in the subpage urls (e.g. /ansatte for parent page and /ansatte/oms for subpage)
  • added support for translation and data fetching for employee subpage (via languageMiddleware.ts and pageData.ts)
  • defined basic UI in EmployeePage.tsx
  • added employee links to employee image in Employees section

Employee Page reference field

image

Basic mini-CV

Desktop

image

Mobile

image

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:25am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:25am

@mathiazom mathiazom force-pushed the feat/v3-employee-page branch from b6b17bc to 7c2d94d Compare October 28, 2024 15:52
@mathiazom mathiazom mentioned this pull request Oct 29, 2024
Merged
@mathiazom mathiazom force-pushed the feat/v3-employee-page branch from 7c2d94d to 0339e5c Compare October 29, 2024 08:48
@mathiazom mathiazom force-pushed the feat/v3-employee-page branch from 0339e5c to 4c077e9 Compare October 29, 2024 13:42
anemne
anemne approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@anemne anemne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👏

@mathiazom mathiazom force-pushed the feat/v3-employee-page branch from 4c077e9 to d14083b Compare October 30, 2024 08:20
@mathiazom mathiazom mentioned this pull request Oct 30, 2024
Closed
@mathiazom mathiazom merged commit 9ecb9f4 into v3 Oct 30, 2024
6 checks passed
@mathiazom mathiazom deleted the feat/v3-employee-page branch October 30, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anemne anemne anemne approved these changes

@trulshj trulshj Awaiting requested review from trulshj

@idamand idamand Awaiting requested review from idamand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathiazom @anemne