Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - customer case main image #792

Merged
merged 1 commit into from
Oct 17, 2024
Merged

v3 - customer case main image #792

merged 1 commit into from
Oct 17, 2024

Conversation

mathiazom
Copy link
Contributor

Added an image field for the primary image required for all customer cases

image

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 1:55pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 1:55pm

@@ -17,9 +17,17 @@ export const CUSTOMER_CASES_QUERY = groq`
}
`;

const INTERNATIONALIZED_IMAGE_FRAGMENT = groq`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do image need to be international? Think we should remove internationalized from name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because the alt text is translated, but I agree it's not a great name

Base automatically changed from feat/v3-case-block-image to v3 October 17, 2024 13:38
@mathiazom mathiazom force-pushed the feat/v3-case-main-image branch from d36c3d9 to 23a6382 Compare October 17, 2024 13:52
@mathiazom mathiazom merged commit 2c64fa3 into v3 Oct 17, 2024
6 checks passed
@mathiazom mathiazom deleted the feat/v3-case-main-image branch October 17, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants