v3 - improve type narrowing for query response data #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
checking `response.data !== null` was not enough to narrow the type of `response` from `QueryResponseInitial<T | null>` to just `QueryResponseInitial<T>`, so a custom type guard has been defined
mathiazom
force-pushed
the
refactor/v3-query-response-type-narrowing
branch
from
7c1ff9f to
23e2915
Compare
anemne
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking
response.data !== nullwas not enough to narrow the type ofresponsefromQueryResponseInitial<T | null>to justQueryResponseInitial<T>, so a custom type guard has been defined