-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 - fetch employees data #767
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ad4a67a
to
5dbf2e7
Compare
f6714c2
to
e6eabee
Compare
5dbf2e7
to
d5edf8e
Compare
e6eabee
to
475de0b
Compare
d5edf8e
to
0b95e99
Compare
0b95e99
to
686bdc4
Compare
An important concern here is that individual employees should have control over whether or not their phone number should be shown as contact info. This is probably something that should be part of Chewbacca and controlled through dash.variant.no so not something that is directly implementable here, but important to design for this possibility. |
009d384
to
bcc240a
Compare
bcc240a
to
be3adb4
Compare
686bdc4
to
c2e0c6c
Compare
How about filtering this out when constructing the Chewbacca response? We would then only need to handle missing values, i.e. having them as optional in employee type. |
c2e0c6c
to
3da0585
Compare
Very basic Proof of Concept for fetching external data for the employees page section.
The section can be added to any dynamic page (aka pageBuilder)