Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - purge unused blog components #758

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

mathiazom
Copy link
Contributor

We don't have any plans for a custom hosted blog, and probably won't for a while.

This is a start at removing boilerplate that we don't actually need. This PR mostly removes unused React components, and there are still some unused schemas and other util functions left. This is left for another PR.

Deleted code is not lost forever, but preserved in the git log. This way we can still use it for reference later, without the burden of maintaining it.

@mathiazom mathiazom requested a review from anemne October 10, 2024 12:54
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 2:20pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 2:20pm

and move remaining folders from /blog to /components
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we don't need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100%, but we can always revisit it if it becomes relevant. The point is just to not lock ourselves into the legacy setup.

@mathiazom mathiazom merged commit db11a8d into v3 Oct 14, 2024
6 checks passed
@mathiazom mathiazom deleted the refactor/v3-purge-blog-components branch October 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants