Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 - language switcher and translated legal links #719

Merged
merged 4 commits into from
Oct 7, 2024
Merged

v3 - language switcher and translated legal links #719

merged 4 commits into from
Oct 7, 2024

Conversation

mathiazom
Copy link
Contributor

@mathiazom mathiazom commented Sep 26, 2024 •
edited
Loading

See #706

Very basic language switcher:

Desktop:
image

Mobile:
image

Also translated legal links:
image

Checklist

Please ensure that you’ve completed the following checkpoints before submitting your pull request:

  • Documentation: Relevant documentation has been added or updated (if applicable).
  • Testing: Have you tested your changes thoroughly?

@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:20am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:20am

@mathiazom mathiazom requested review from anemne and christinaroise and removed request for anemne September 26, 2024 19:19
@mathiazom mathiazom marked this pull request as draft September 26, 2024 19:19
@mathiazom mathiazom force-pushed the feat/v3-language-switcher-and-legal-links branch from 6aa3f8e to f2d3764 Compare September 27, 2024 09:33
@mathiazom mathiazom marked this pull request as ready for review September 27, 2024 09:33
@mathiazom mathiazom force-pushed the feat/v3-language-switcher-and-legal-links branch from f2d3764 to ac11556 Compare September 27, 2024 09:42
christinaroise
christinaroise reviewed Sep 27, 2024
View reviewed changes
src/components/languageSwitcher/LanguageSwitcher.tsx Outdated Show resolved Hide resolved
src/components/navigation/footer/Footer.tsx Outdated Show resolved Hide resolved
src/components/navigation/header/Header.tsx Show resolved Hide resolved
src/utils/hooks/useLanguage.ts Outdated Show resolved Hide resolved
src/utils/hooks/useLanguage.ts Outdated Show resolved Hide resolved
src/utils/hooks/useLanguage.ts Show resolved Hide resolved
@mathiazom mathiazom force-pushed the feat/v3-language-switcher-and-legal-links branch from cbeca1b to e8a7438 Compare September 27, 2024 11:22
@mathiazom mathiazom force-pushed the feat/v3-language-switcher-and-legal-links branch from 17849fd to d0b457d Compare September 27, 2024 12:16
@mathiazom mathiazom requested a review from anemne September 27, 2024 12:18
anemne
anemne approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@anemne anemne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mathiazom mathiazom force-pushed the feat/v3-language-switcher-and-legal-links branch from d0b457d to aa8c0b6 Compare September 29, 2024 10:49
@mathiazom
fix(siteSettings): inline document id in groq query
156bf7a 
attempt to fix following error at build:
> The error was caused by importing 'sanity/lib/index.mjs' in './studio/schemas/documents/siteSettings/brandAssets.ts'.
@mathiazom mathiazom merged commit 87f4564 into v3 Oct 7, 2024
6 checks passed
@mathiazom mathiazom deleted the feat/v3-language-switcher-and-legal-links branch October 7, 2024 07:21
@mathiazom mathiazom mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anemne anemne anemne approved these changes

@christinaroise christinaroise christinaroise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathiazom @christinaroise @anemne