v3 - proper slug change validation #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1,5 +1,6 @@ | |||
| import { SlugValidationContext, defineField } from "sanity"; | |||
There was a problem hiding this comment.
This file is starting to look a little bloated, and we've got a lot of if, else, and, or. Do we have time to clean it up for easier dev experience upon handoff?
There was a problem hiding this comment.
Extracted the validation logic into a separate utility function now. We could also move it to a different file if you want.
mathiazom
force-pushed
the
feat/v3-proper-slug-change-check
branch
from
6e7c1aa to
37c260d
Compare
anemne
approved these changes
Sep 24, 2024
christinaroise
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #696
The originally approach to prevent slug changes after publication was too naive. It only checked if the current document was a draft or not. This meant that the slug could be changed for a published document by first changing a different field (e.g. the page title), and then change the slug field.
The new approach relies on validation to perform a client fetch to check if a published document exists with the same id (without the
drafts.prefix) with a different slug. This is less clear than the readonly state, but the readonly property does not seem to allow async.Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request: