v3 - Variant profile #681
Merged
v3 - Variant profile #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
christinaroise
approved these changes
Sep 19, 2024
| @@ -99,7 +99,7 @@ const Compensations = ({ compensations, locations }: CompensationsProps) => { | |||
| <Text type="h1">{compensations.basicTitle}</Text> | |||
| <RadioButtonGroup | |||
| id="location-group" | |||
| label="Choose your location" | |||
There was a problem hiding this comment.
this reminds me, we need to find all hardcoded strings that are in need of translations!
mathiazom
force-pushed
the
feat/v3-variant-profile
branch
from
956166a to
9b2828c
Compare
anemne
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #677 and #678
Replaced color variables with Variant colors, and added the custom font Recoleta for headers. Even though the desing is not ready, and this is the legacy profile, we should not be using the profile of the previous project 🙃
Updated color palette, as seen in Storybook:
Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request: