Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 - Show Benefits by location #609

Merged
merged 5 commits into from
Sep 12, 2024
Merged

v3 - Show Benefits by location #609

merged 5 commits into from
Sep 12, 2024

Conversation

anemne
Copy link
Contributor

@anemne anemne commented Sep 11, 2024 •
edited by mathiazom
Loading

Display benefits related to the chosen office location.

Visual Overview (Image/Video)

Screenshot 2024-09-11 at 10 31 44 Screenshot 2024-09-11 at 10 32 04

Checklist

Please ensure that you’ve completed the following checkpoints before submitting your pull request:

  • Documentation: Relevant documentation has been added or updated (if applicable).
  • Testing: Have you tested your changes thoroughly?
    • Please list the types of tests you've run (unit, integration, manual, etc.):

Additional Notes

Related issue: #608

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 0:46am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 0:46am

@mathiazom
Copy link
Contributor

Not introduced in this PR, but the BenefitsByLocation payload type should match the schema. More specifically, the benefits property is actually named benefitsGroup in the schema. I think we should rename it to benefits in the schema, and omit the extra terminology "Benefits Group".

mathiazom
mathiazom approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@mathiazom mathiazom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@anemne anemne merged commit 6b7aaed into v3 Sep 12, 2024
6 checks passed
@anemne anemne deleted the v3-calculator-ui-benefits branch September 12, 2024 11:06
@mathiazom mathiazom mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinaroise christinaroise christinaroise approved these changes

@mathiazom mathiazom mathiazom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anemne @mathiazom @christinaroise