Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - read-only slug for published documents #586

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mathiazom
Copy link
Contributor

@mathiazom mathiazom commented Sep 5, 2024

Alternative solution to #560

All slug fields have been made read-only when the related document is published.


Visual Overview (Image/Video)

Draft Published
image image

Checklist

Please ensure that you’ve completed the following checkpoints before submitting your pull request:

  • Documentation: Relevant documentation has been added or updated (if applicable).
  • Testing: Have you tested your changes thoroughly?

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 7:25am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 7:25am

@anemne
Copy link
Contributor

anemne commented Sep 5, 2024

Maybe we should add an alert or notify that it's not possible to change the slug after its pusblished?

/*
make slugs read-only after initial publish
to avoid breaking shared links
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add that these can be changed in the redirect? or some documentation for how slugs and redirects are related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That feature is not available yet though, maybe add it in the redirects PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will you make a note of it so not to forget?

@mathiazom mathiazom merged commit 32e01ac into v3 Sep 5, 2024
6 checks passed
@mathiazom mathiazom deleted the feat/v3-readonly-slug-after-publish branch September 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants