Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - company location as type #583

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

mathiazom
Copy link
Contributor

@mathiazom mathiazom commented Sep 4, 2024

The company location document schema should be defined as a type, not field. This is more consistent with the rest of the codebase.

Checklist

Please ensure that you’ve completed the following checkpoints before submitting your pull request:

  • Documentation: Relevant documentation has been added or updated (if applicable).
  • Testing: Have you tested your changes thoroughly?

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 1:57pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 1:57pm

Copy link
Contributor

@anemne anemne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mathiazom mathiazom merged commit 34a43f8 into v3 Sep 5, 2024
6 checks passed
@mathiazom mathiazom deleted the refactor/v3-company-location-as-type branch September 5, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants