You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id used for the company location document was in plural. This is confusing as there is also a field accepting multiple locations using the plural form. The location name of the location document has been given a separate id.
Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request:
Documentation: Relevant documentation has been added or updated (if applicable).
the document companyLocations is a list of companyLocations.. hence plural.
No, the document itself only represents a single location. However, multiple company locations can be defined via Studio because of documentTypeList(companyLocationID). This is the same as legal documents and dynamic pages. The field locations in studio/schemas/objects/locations.ts can be plural because that is a field for an array of multiple locations.
No, the document itself only represents a single location. However, multiple company locations can be defined via Studio because of documentTypeList(companyLocationID). This is the same as legal documents and dynamic pages. The field locations in studio/schemas/objects/locations.ts can be plural because that is a field for an array of multiple locations.
Good point. Perhaps we should add some cleanup in this pr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathiazom
force-pushed
the
refactor/v3-plural-compay-location-confusion
branch
from
The id used for the company location document was in plural. This is confusing as there is also a field accepting multiple locations using the plural form. The location name of the location document has been given a separate id.
Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request: