Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - hotfix page conditional render #570

Merged
merged 1 commit into from
Sep 4, 2024
Merged

v3 - hotfix page conditional render #570

merged 1 commit into from
Sep 4, 2024

Conversation

mathiazom
Copy link
Contributor

@mathiazom mathiazom commented Sep 3, 2024

Incorrect variable name caused the dynamic page rendering to fail. This has now been fixed.


Checklist

Please ensure that you’ve completed the following checkpoints before submitting your pull request:

  • Documentation: Relevant documentation has been added or updated (if applicable).
  • Testing: Have you tested your changes thoroughly?

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 5:46am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 5:46am

@christinaroise
Copy link
Contributor

Just a headsup that we don't do anything else than fixing the issue in a hotfix. So refactoring would not be accepted in a hotfix

@mathiazom
Copy link
Contributor Author

Just a headsup that we don't do anything else than fixing the issue in a hotfix. So refactoring would not be accepted in a hotfix

Very good point! Removed the refactoring here and created separate PR: #572

@mathiazom mathiazom merged commit aab56a1 into v3 Sep 4, 2024
6 checks passed
@mathiazom mathiazom deleted the hotfix/v3-initialPage branch September 4, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants