Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - InformationMessage Component + replacement in main/page.tsx #532

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

anemne
Copy link
Contributor

@anemne anemne commented Aug 27, 2024

Short Description

Created an informationmessage component to be used in landingpage

Visual Overview (Image/Video)

If applicable, please include screenshots or a short video showcasing the changes you have made.

Screenshot 2024-08-27 at 14 03 10

Checklist

Please ensure that you’ve completed the following checkpoints before submitting your pull request:

  • Documentation: Relevant documentation has been added or updated (if applicable).
  • Testing: Have you tested your changes thoroughly?
    • Please list the types of tests you've run (unit, integration, manual, etc.):

Additional Notes

Other comments relevant to this pull request.

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:29am

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@anemne anemne changed the title InformationMessage Component + replacement in main/page.tsx v3 - InformationMessage Component + replacement in main/page.tsx Aug 27, 2024
@christinaroise
Copy link
Contributor

This is so much better! 👏

I've approved, but did live a few comments. Like mentioned earlier that means they're not crucial and however you choose to adjust is fine by me. If you've got any questions let me know!

@anemne anemne merged commit 98c36f4 into v3 Aug 28, 2024
4 of 5 checks passed
@anemne anemne deleted the v3-landingpage branch August 28, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants