fix: dont load entire images to check if they exist #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
petterhh
approved these changes
Dec 18, 2024
|
This also explains the annoying 404 I've seen when loading the page.. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check for where the image is stored, the client actually fetches the image in addition to actually load it as an image. This check I think is only ment to construct an URL with correct metadata, so this is unnecessary. I don't have time to prioritise for a proper fix and avoid this issue properly, but as a temporary measure we can at least avoid loading 5-6 megs of images just to check if they exists.
Again: We shouldn't have it like this, and we should find a proper way to separate shared studio image vs non-shared. But to avoid downloading lots of lots of data that isn't used, we could at least do some temporary workarounds.
Before:
After:
