Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing translations for bonus stuff #1071

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add missing translations for bonus stuff #1071

merged 2 commits into from
Dec 18, 2024

Conversation

petterhh
Copy link
Contributor

@petterhh petterhh commented Dec 17, 2024 •
edited
Loading

Summary

  • Add missing translations for bonus stuff
  • Change wording from "Velg lokasjon" to "Lokasjon", as we we don't use the "Velg"/"Select" prefix in other filters.
  • Change wording from "Historisk bonus" to simply "Bonuser"/"Bonuses", as it's obvious from the years in "Year" column that it's for previous years. Aaaand "historisk bonus" makes it sound like it's the greatest bonus in history 😅 I guess we could use "Tidligere bonuser" or "Årlige bonuser" instead? Thoughts?

Screenshots

Before

Screenshot 2024-12-17 at 11 58 37

After

Screenshot 2024-12-17 at 11 58 43

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:27am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:27am

@petterhh petterhh force-pushed the petterhh/fix/bonus-missing-translation branch from ffd16dd to b4df198 Compare December 17, 2024 11:19
@petterhh petterhh marked this pull request as ready for review December 17, 2024 11:38
anemne
anemne reviewed Dec 18, 2024
View reviewed changes
messages/no.json Outdated Show resolved Hide resolved
@petterhh petterhh merged commit 2760dfc into v3 Dec 18, 2024
6 checks passed
@petterhh petterhh deleted the petterhh/fix/bonus-missing-translation branch December 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anemne anemne anemne approved these changes

@mikaelbr mikaelbr Awaiting requested review from mikaelbr

@trulshj trulshj Awaiting requested review from trulshj

@idamand idamand Awaiting requested review from idamand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petterhh @anemne