v3 - fix sanity internal links (#763)

* fix(link): broken links and root fix * refactor(utils): rename get.tsx → link.ts
varianter · Oct 14, 2024 · 9b4b6a0 · 9b4b6a0
1 parent 3d7ecca
commit 9b4b6a0
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 15 deletions.
diff --git a/src/app/(main)/[lang]/page.tsx b/src/app/(main)/[lang]/page.tsx
@@ -30,7 +30,7 @@ const navigationManagerLink = {
   _type: "link",
   linkTitle: "Go to Navigation Manager",
   linkType: LinkType.Internal,
-  internalLink: { _ref: "studio/structure/navigationManager" },
+  internalLink: { _ref: "studio/structure/siteSettings;navigationManager" },
 };
 
 const pagesLink = {

diff --git a/src/components/link/CustomLink.tsx b/src/components/link/CustomLink.tsx
@@ -1,7 +1,7 @@
 import Link from "next/link";
 import React from "react";
 
-import { getHref } from "src/utils/get";
+import { getHref } from "src/utils/link";
 import { ILink } from "studio/lib/interfaces/navigation";
 
 import styles from "./link.module.css";

diff --git a/src/components/linkButton/LinkButton.tsx b/src/components/linkButton/LinkButton.tsx
@@ -1,6 +1,6 @@
 import React from "react";
 
-import { getHref } from "src/utils/get";
+import { getHref } from "src/utils/link";
 import { ILink } from "studio/lib/interfaces/navigation";
 
 import styles from "./linkButton.module.css";

diff --git a/src/components/navigation/header/Header.tsx b/src/components/navigation/header/Header.tsx
@@ -9,7 +9,7 @@ import { SanityImage } from "src/components/image/SanityImage";
 import LanguageSwitcher from "src/components/languageSwitcher/LanguageSwitcher";
 import CustomLink from "src/components/link/CustomLink";
 import LinkButton from "src/components/linkButton/LinkButton";
-import { getHref } from "src/utils/get";
+import { getHref } from "src/utils/link";
 import { BrandAssets } from "studio/lib/interfaces/brandAssets";
 import { ILink, Navigation } from "studio/lib/interfaces/navigation";
 import { callToActionFieldID } from "studio/schemas/fields/callToActionFields";

diff --git a/src/components/utils/linkTypes.ts b/src/components/utils/linkTypes.ts
@@ -6,7 +6,7 @@ export const homeLink = {
   linkTitle: "Return to home",
   linkType: LinkType.Internal,
   internalLink: {
-    _ref: "/",
+    _ref: "",
   },
 };
 

diff --git a/src/utils/get.tsx → src/utils/link.ts b/src/utils/get.tsx → src/utils/link.ts
@@ -3,15 +3,10 @@ import { ILink, LinkType } from "studio/lib/interfaces/navigation";
 const hash = "#";
 
 export const getHref = (link: ILink): string => {
-  switch (link?.linkType) {
+  switch (link.linkType) {
     case LinkType.Internal:
-      if (link.internalLink?._ref) {
-        try {
-          return `${link.language ? `/${link.language}` : ""}/${link.internalLink._ref}${link.anchor ? `#${link.anchor}` : ""}`;
-        } catch (error) {
-          console.error("Error fetching page:", error);
-          return hash;
-        }
+      if (link.internalLink?._ref !== undefined) {
+        return `${link.language ? `/${link.language}` : ""}/${link.internalLink._ref}${link.anchor ? `#${link.anchor}` : ""}`;
       }
       return hash;
     case LinkType.External:
@@ -20,7 +15,5 @@ export const getHref = (link: ILink): string => {
       return `mailto:${link.email}`;
     case LinkType.Phone:
       return `tel:${link.phone}`;
-    default:
-      return hash;
   }
 };