feat(preview): throw TypeError if internationalizedArrayString fails …

…type guard
varianter · Oct 10, 2024 · 802cc57 · 802cc57
1 parent 51e1bfc
commit 802cc57
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 16 deletions.
diff --git a/studio/schemas/documents/compensations.ts b/studio/schemas/documents/compensations.ts
@@ -49,11 +49,13 @@ const compensations = defineType({
       title: title.name,
     },
     prepare({ title }) {
-      const translatedTitle = isInternationalizedString(title)
-        ? firstTranslation(title)
-        : null;
+      if (!isInternationalizedString(title)) {
+        throw new TypeError(
+          `Expected 'title' to be InternationalizedString, was ${typeof title}`,
+        );
+      }
       return {
-        title: translatedTitle ?? undefined,
+        title: firstTranslation(title) ?? undefined,
       };
     },
   },

diff --git a/studio/schemas/fields/callToActionFields.ts b/studio/schemas/fields/callToActionFields.ts
@@ -18,11 +18,13 @@ const callToActionField = defineField({
       title: "linkTitle",
     },
     prepare({ title }) {
-      const translatedTitle = isInternationalizedString(title)
-        ? firstTranslation(title)
-        : null;
+      if (!isInternationalizedString(title)) {
+        throw new TypeError(
+          `Expected 'title' to be InternationalizedString, was ${typeof title}`,
+        );
+      }
       return {
-        title: translatedTitle ?? undefined,
+        title: firstTranslation(title) ?? undefined,
         subtitle: "Call to Action",
       };
     },

diff --git a/studio/schemas/objects/compensations/benefitsByLocation.ts b/studio/schemas/objects/compensations/benefitsByLocation.ts
@@ -80,14 +80,16 @@ export const benefitsByLocation = defineField({
                   type: benefitType.name,
                 },
                 prepare({ title, type }) {
-                  const translatedTitle = isInternationalizedString(title)
-                    ? firstTranslation(title)
-                    : null;
+                  if (!isInternationalizedString(title)) {
+                    throw new TypeError(
+                      `Expected 'title' to be InternationalizedString, was ${typeof title}`,
+                    );
+                  }
                   const subtitle =
                     BENEFIT_TYPES.find((o) => o.value === type)?.title ??
                     "Unknown benefit type";
                   return {
-                    title: translatedTitle ?? undefined,
+                    title: firstTranslation(title) ?? undefined,
                     subtitle,
                   };
                 },

diff --git a/studio/schemas/objects/link.ts b/studio/schemas/objects/link.ts
@@ -193,11 +193,13 @@ export const link = defineField({
       type: "linkType",
     },
     prepare({ title, type }) {
-      const translatedTitle = isInternationalizedString(title)
-        ? firstTranslation(title)
-        : null;
+      if (!isInternationalizedString(title)) {
+        throw new TypeError(
+          `Expected 'title' to be InternationalizedString, was ${typeof title}`,
+        );
+      }
       return {
-        title: translatedTitle ?? undefined,
+        title: firstTranslation(title) ?? undefined,
         subtitle: type ? type.charAt(0).toUpperCase() + type.slice(1) : "",
       };
     },