357 flag linux windows os #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
use intl_mobile_field package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the change in #243, flags in Windows and Linux are not shown anymore.
This is due to the render of icon that is not supported in these platforms. There is already a check to determine if the platform is Web to render the .png. I added some additionnal check on Platform Linux and Windows to render pgn too.
This was tested in Linux and Windows. On MacOs, icon are correctly render so no need to switch to png.
In order to run it, I also enabled desktop OS project in the example. It created automatically a bunch of files, so it can be removed it if you prefer.
Close #357