-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed ai issue #36
fixed ai issue #36
Conversation
@Sourabh782 is attempting to deploy a commit to the vansh-codes1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@vansh-codes kindly review it |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the package-lock.json and remove unwanted dependencies
package-lock.json
Outdated
@@ -243,12 +244,13 @@ | |||
} | |||
}, | |||
"node_modules/@next/swc-darwin-arm64": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all this unwanted dependencies from PR, it was for your system and it shouldnt be required to everyone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vansh-codes can you specify which ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the nextjs version one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-darwin-arm64
linux
node_modules/@next/swc-linux-arm64-gnu
msvc
and many more such linux and darwins dependencies
I guess you use linux thats why it was needed for you, but ig its not needed in the project, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the nextjs one, the other ones in package-lock.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vansh-codes i copied you current files, the only diff were of nextjs versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sourabh782 I am talking about package-lock.json
and not package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup copied both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it still showing this? i actually just copied your package-lock.json and make a commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅
@vansh-codes this issue was marked level 2, can you fix it in pr? |
Acccording to the changes, it gets level1, i thought it would be complex thats why I mentioned level2 on the issue but its only 40 lines change, cant give level2 |
sir you can see changes in files, fixing routes, and solving error, also as it was marked level 2 initially. |
Thanks @vansh-codes sir :)) Really appreciated |
Fixes #32