Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ai issue #36

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fixed ai issue #36

merged 2 commits into from
Oct 14, 2024

Conversation

Sourabh782
Copy link
Contributor

Fixes #32

Copy link

vercel bot commented Oct 13, 2024

@Sourabh782 is attempting to deploy a commit to the vansh-codes1's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Sourabh782
Copy link
Contributor Author

@vansh-codes kindly review it

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gityzer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 5:19am

Copy link
Owner

@vansh-codes vansh-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the package-lock.json and remove unwanted dependencies

@@ -243,12 +244,13 @@
}
},
"node_modules/@next/swc-darwin-arm64": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all this unwanted dependencies from PR, it was for your system and it shouldnt be required to everyone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vansh-codes can you specify which ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the nextjs version one?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-darwin-arm64
linux
node_modules/@next/swc-linux-arm64-gnu
msvc
and many more such linux and darwins dependencies

I guess you use linux thats why it was needed for you, but ig its not needed in the project, right?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the nextjs one, the other ones in package-lock.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vansh-codes i copied you current files, the only diff were of nextjs versions

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sourabh782 I am talking about package-lock.json and not package.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup copied both

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still showing this? i actually just copied your package-lock.json and make a commit

Copy link
Owner

@vansh-codes vansh-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@vansh-codes vansh-codes merged commit f472145 into vansh-codes:master Oct 14, 2024
1 check failed
@vansh-codes vansh-codes added bug Something isn't working AI working on enhancing AI gssoc-ext GSSOC'24 Extd Participant level1 awards 10 points hacktoberfest hacktoberfest registered hacktoberfest-accepted hacktoberfest accepted and removed changes requested labels Oct 14, 2024
@Sourabh782
Copy link
Contributor Author

@vansh-codes this issue was marked level 2, can you fix it in pr?

@vansh-codes
Copy link
Owner

Acccording to the changes, it gets level1, i thought it would be complex thats why I mentioned level2 on the issue but its only 40 lines change, cant give level2
But good job!

@Sourabh782
Copy link
Contributor Author

sir you can see changes in files, fixing routes, and solving error, also as it was marked level 2 initially.

@vansh-codes vansh-codes added level2 awards 25 points and removed level1 awards 10 points labels Oct 14, 2024
@Sourabh782
Copy link
Contributor Author

Thanks @vansh-codes sir :)) Really appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI working on enhancing AI bug Something isn't working gssoc-ext GSSOC'24 Extd Participant hacktoberfest hacktoberfest registered hacktoberfest-accepted hacktoberfest accepted level2 awards 25 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

**HIGH PRIORITY** BUG: FIX AI TAGLINE generation
2 participants