Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the workflow issue #10 #13

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

HarshitShukla-dev
Copy link
Contributor

@HarshitShukla-dev HarshitShukla-dev commented Oct 7, 2024

Closes: #10

Problem

The GitHub Action failed with a SyntaxError: Unexpected end of input due to improper async handling in the script.

Solution

  • Wrapped the comment creation logic in an async function to fix the issue.
  • Changed the version of github-script@v5 to github-script@v7

Testing

Tested on a private repository to ensure comments are posted correctly on issue closure.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gityzer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 5:05pm

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@vansh-codes vansh-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@vansh-codes vansh-codes added documentation Improvements or additions to documentation good first issue Good for newcomers gssoc-ext GSSOC'24 Extd Participant level1 awards 10 points hacktoberfest hacktoberfest registered hacktoberfest-accepted hacktoberfest accepted labels Oct 7, 2024
@vansh-codes vansh-codes merged commit 257200a into vansh-codes:master Oct 7, 2024
2 checks passed
@vansh-codes
Copy link
Owner

Add a line at the top of description
Closes: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers gssoc-ext GSSOC'24 Extd Participant hacktoberfest hacktoberfest registered hacktoberfest-accepted hacktoberfest accepted level1 awards 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Fix Autocomment on issue close workflow
2 participants