-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle 8 upgrade #223
base: master
Are you sure you want to change the base?
Gradle 8 upgrade #223
Conversation
@themockgraeme I have added the code review changes from #219. I could not push to your branch, so I created this one. Could you please give it a quick review? |
Hey guys .... This seem to take forever to merge, do we have any workarounds for this until this is merged? cc @john-tadebois john |
I do not know much about the inner workings of this plugin. My team has moved on to directly use JaCoCo. I can still merge that PR if you do understand and can confirm in this chat that I can go ahead and merge this PR. |
I pushed this branch from themockgrateme:gradle-8-upgrade, with the fix for
POM_IMPLEMENTATION_CLASS = com.vanniktech.android.junit.jacoco.GenerationPlugin
Along with themockgraeme's changes:
#219