Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 8 upgrade #223

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Gradle 8 upgrade #223

wants to merge 13 commits into from

Conversation

john-tadebois
Copy link
Collaborator

@john-tadebois john-tadebois commented Jan 3, 2024

I pushed this branch from themockgrateme:gradle-8-upgrade, with the fix for

POM_IMPLEMENTATION_CLASS = com.vanniktech.android.junit.jacoco.GenerationPlugin

Along with themockgraeme's changes:

#219

I forked the Laimiux Gradle 8 compatible branch of the Vanniktech Jacoco plugin and made the following changes:

Removed the Laimiux publishing calls, which are specific to their system.
Upgraded the included APIs to the latest versions and made minor code changes to accommodate these.
Changed the Java / JDK version to 17, for compatibility with Gradle 8.
Upgraded the Gradle version to 8.

@john-tadebois
Copy link
Collaborator Author

@themockgraeme I have added the code review changes from #219.

I could not push to your branch, so I created this one. Could you please give it a quick review?

@unamed000
Copy link

Hey guys ....

This seem to take forever to merge, do we have any workarounds for this until this is merged?

cc @john-tadebois john

@john-tadebois
Copy link
Collaborator Author

Hey guys ....

This seem to take forever to merge, do we have any workarounds for this until this is merged?

cc @john-tadebois john

I do not know much about the inner workings of this plugin.

My team has moved on to directly use JaCoCo.

I can still merge that PR if you do understand and can confirm in this chat that I can go ahead and merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants