Add strings for ROI calculator #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhovhannes
requested changes
Oct 22, 2024
tx-source/dash_core.php
Outdated
| @@ -725,6 +728,7 @@ | |||
|
|
|||
| $Definition['Page Color'] = 'Page Color'; | |||
| $Definition['Page Views'] = 'Page Views'; | |||
| $Definition['Page Views'] = 'Pageview ratio representing a deflected case'; | |||
There was a problem hiding this comment.
This is probably not right ? :)
There was a problem hiding this comment.
🤦♀️ Ooooops, thanks for catching that! Should be fixed now in b1a3fa4 😄
hhovhannes
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding strings for the ROI calculator, frontend PR here: https://github.com/vanilla/vanilla-cloud/pull/8351