Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make createInstance method protected #50

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Make createInstance method protected #50

merged 1 commit into from
Dec 15, 2023

Conversation

acharron-hl
Copy link
Contributor

Simple tweak so we can extend it slightly in vanilla.

@acharron-hl acharron-hl requested a review from a team December 15, 2023 15:52
thundrax
thundrax approved these changes Dec 15, 2023
View reviewed changes
Copy link

@thundrax thundrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acharron-hl acharron-hl merged commit ace9101 into master Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thundrax thundrax thundrax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acharron-hl @thundrax