Early redemption of fully assigned Claims #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VAL-869 Early redemption of fully assigned Claims
AC
|
neodaoist
changed the base branch from
v1.1.0
to
neo/val-1202-set-the-table-of-net-offsetting-positions
0xAlcibiades
requested changes
Sep 9, 2023
| @@ -992,20 +992,6 @@ contract ValoremOptionsClearinghouseUnitTest is BaseClearinghouseTest { | |||
| vm.stopPrank(); | |||
| } | |||
|
|
|||
| function testRevert_redeem_whenClaimTooSoon() public { | |||
There was a problem hiding this comment.
This test should not go away, but rather be altered to catch the remaining cases.
There was a problem hiding this comment.
It moved to the other 1.1 test file.
There was a problem hiding this comment.
My thinking is it will be cleaner for the auditors to encapsulate all 1.1 functionality in its own test class. Open to otherwise tho.
neodaoist
changed the title
… into neo/val-869-early-redemption-of-fully-assigned-claims
0xAlcibiades
approved these changes
Sep 12, 2023
…of github.com:valorem-labs-inc/clear into neo/val-869-early-redemption-of-fully-assigned-claims
Codecov Report
@@ Coverage Diff @@
## neo/val-1202-set-the-table-of-net-offsetting-positions #218 +/- ##
=========================================================================================
Coverage ? 99.20%
=========================================================================================
Files ? 1
Lines ? 251
Branches ? 41
=========================================================================================
Hits ? 249
Misses ? 0
Partials ? 2 |
neodaoist
merged commit 73f1522
into
neo/val-1202-set-the-table-of-net-offsetting-positions
4 checks passed
neodaoist
deleted the
neo/val-869-early-redemption-of-fully-assigned-claims
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.