Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): use the custom Switch component #6194

Open
wants to merge 2 commits into
base: satish/act-1432-1
Choose a base branch
from

Conversation

satish-ravi
Copy link
Contributor

Description

Ensured all switch use the custom switch component instead of the native one to be consistent.

Test plan

Platform Before After
iOS
toggle-before-ios.mp4
toggle-after-ios.mp4
Android
toggle-before-android.webm
toggle-after-android.webm

Related issues

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (8b3690f) to head (6227ecc).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           satish/act-1432-1    #6194   +/-   ##
==================================================
  Coverage              88.89%   88.90%           
==================================================
  Files                    733      733           
  Lines                  31144    31145    +1     
  Branches                5716     5719    +3     
==================================================
+ Hits                   27686    27690    +4     
+ Misses                  3261     3258    -3     
  Partials                 197      197           
Files with missing lines Coverage Δ
src/components/SettingsItem.tsx 97.46% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3690f...6227ecc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants