Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the right colors #6193

Open
wants to merge 2 commits into
base: satish/act-1432-1
Choose a base branch
from
Open

Conversation

satish-ravi
Copy link
Contributor

Description

Changes include:

  • Segmented control defaults to black instead of accent (only used in QR scanner screen)
  • Change black to accent in a few places in the CAB / recovery phrase flows
  • Change "Sign in another way" from secondary to text button with TextButton
  • Remove unused progress dots colors

Checked with design on all these

Test plan

Feature Before After
QR Scanner
Onboarding recovery phrase
Progress dots
CAB intro settings
CAB intro onboarding

Related issues

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (8b3690f) to head (2e7a188).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           satish/act-1432-1    #6193      +/-   ##
=====================================================
- Coverage              88.89%   88.89%   -0.01%     
=====================================================
  Files                    733      733              
  Lines                  31144    31145       +1     
  Branches                5716     5719       +3     
=====================================================
  Hits                   27686    27686              
- Misses                  3261     3262       +1     
  Partials                 197      197              
Files with missing lines Coverage Δ
src/components/SegmentedControl.tsx 80.55% <100.00%> (ø)
src/keylessBackup/KeylessBackupIntro.tsx 95.45% <ø> (ø)
src/keylessBackup/SignInWithEmail.tsx 98.13% <100.00%> (+0.01%) ⬆️
...boarding/registration/OnboardingRecoveryPhrase.tsx 86.79% <ø> (ø)
src/styles/progressDots.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3690f...2e7a188. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants