feat(earn): prepare transactions and use on confirmation screen #6192
Conversation
src/earn/EarnConfirmationScreen.tsx
Outdated
| }) | ||
| // @ts-expect-error prepareTransactionsResult & swapTransaction are only set when mode === 'deposit' or 'swap-deposit' |
There was a problem hiding this comment.
I don't understand these two lines.
- Seems like a red flag to do a ts-ignore here. if the return values of the different modes are that different then should they maybe be changed at the prepare transaction level?
- swapTransaction doesn't even seem to be used in the code.
There was a problem hiding this comment.
This ts-expect-error is temporary; I'll remove it before moving the PR out of draft and resolving the type issues. While swapTransaction isn't currently used on this page there's a bug with the bottom sheet implementation that will likely require swap-deposit and deposit to be handled from a confirmation screen.
src/earn/EarnConfirmationScreen.tsx
Outdated
| pool, | ||
| hooksApiUrl, | ||
| // Mode === shortcutId, except for exit which is withdraw | ||
| shortcutId: mode === 'exit' ? 'withdraw' : mode, |
There was a problem hiding this comment.
So exit maps to 'prepareWithdrawAndClaimTransactions' which doesn't appear to have shortcutId as a parameter. So why is this needed?
src/earn/EarnEnterAmount.tsx
Outdated
| @@ -144,6 +144,7 @@ function EarnEnterAmount({ route }: Props) { | |||
| } | |||
|
|
|||
| const { | |||
| // @ts-expect-error prepareTransactionsResult & swapTransaction are only set when mode === 'deposit' or 'swap-deposit' | |||
There was a problem hiding this comment.
Again, the ts-expects-error is a big red flag. The underlying types should probably be changed or we just need separate functions
src/earn/prepareTransactions.ts
Outdated
|
|
||
| // Prepare the claim transactions if there are rewards positions | ||
| const claimTransactions = rewardsPositions | ||
| ? await Promise.all( |
There was a problem hiding this comment.
this checks if rewardsPositions is falsy, but can it ever be falsy since its guarenteed to be an array?
Description
Handles the preparation of all earn transactions via a shared hook that's used on both
EarnEnterAmount.tsx&EarnConfirmationScreen.tsx.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A