-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedV2): consolidate earn types into deposit and withdraw #6189
base: jeanregisser/remove-typename
Are you sure you want to change the base?
feat(feedV2): consolidate earn types into deposit and withdraw #6189
Conversation
timestamp: number | ||
block: string | ||
fees: Fee[] | ||
providerName: string | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we could also keep providerId
and would use it first.
providerName
would be used as a fallback. For all the other dapps Zerion already knows about.
EarnWithdraw = 'EARN_WITHDRAW', | ||
/** @deprecated Use Received instead */ | ||
EarnClaimReward = 'EARN_CLAIM_REWARD', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't implemented the changes to Received
yet in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the implementation here and in other files is a copy of the Earn components, just adapted for the new types.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jeanregisser/remove-typename #6189 +/- ##
================================================================
+ Coverage 88.88% 88.89% +0.01%
================================================================
Files 733 735 +2
Lines 31166 31270 +104
Branches 5736 5465 -271
================================================================
+ Hits 27702 27798 +96
- Misses 3265 3427 +162
+ Partials 199 45 -154
... and 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
Test plan
Related issues
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: