Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): enable no-shadow rule #6099

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

satish-ravi
Copy link
Contributor

Description

Test plan

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (5190cda) to head (709ba5a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6099    +/-   ##
========================================
  Coverage   88.73%   88.73%            
========================================
  Files         727      727            
  Lines       30763    30763            
  Branches     5611     5306   -305     
========================================
  Hits        27298    27298            
- Misses       3267     3422   +155     
+ Partials      198       43   -155     

see 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5190cda...709ba5a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant