refactor(component): Remove autocomplete functionality

This hasn't been working for a while and can easily be implemented by the code using ng2-handsontable. (see https://docs.handsontable.com/demo-autocomplete.html)
valor-software · Apr 9, 2018 · 300499e · 300499e
1 parent b1fb869
commit 300499e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 41 deletions.
diff --git a/demo/src/components/handsontable/basic-demo.ts b/demo/src/components/handsontable/basic-demo.ts
@@ -28,11 +28,7 @@ export class BasicDemoComponent {
     },
     {
       data: 'product.description',
-      source: 'product.options',
-      optionField: 'description',
-      type: 'autocomplete',
-      strict: false,
-      visibleRows: 4
+      renderer: 'text'
     },
     {
       data: 'price',

diff --git a/src/handsontable.component.ts b/src/handsontable.component.ts
@@ -202,8 +202,6 @@ export class HotTableComponent implements OnInit, OnDestroy, OnChanges {
       this.inst = new Handsontable(this.view, options);
     });
 
-    this.parseAutoComplete(options);
-
     if (this.pagedData) {
       this.data = [];
       this.pagedDataSubscription = this.pagedData.subscribe((newPagedData: any) => {
@@ -212,7 +210,6 @@ export class HotTableComponent implements OnInit, OnDestroy, OnChanges {
           this.inst.loadData(this.data);
           this.inst.updateSettings(options, false);
         });
-        this.parseAutoComplete(options);
       });
     }
   }
@@ -245,39 +242,6 @@ export class HotTableComponent implements OnInit, OnDestroy, OnChanges {
     this.markAsChanged(properties);
   }
 
-  private parseAutoComplete(options: any) {
-    const columns = this.columns || options.columns;
-    const dataSet = options.data;
-
-    if (columns) {
-      columns.forEach((column: any) => {
-        if (typeof column.source === 'string') {
-          const relatedField: string = column.source;
-          column.source = (_query: any, process: any) => {
-            const row: number = this.ngZone.runOutsideAngular(() =>
-              this.inst.getSelected()[0][0]
-            );
-            const data: any = dataSet[row];
-
-            if (!data) {
-              return;
-            }
-
-            const fieldParts: string[] = relatedField.split('.');
-            let o: any = data;
-            for (const part of fieldParts) {
-              o = o[part];
-            }
-
-            process(o.map((item: any) => {
-              return !column.optionField ? item : item[column.optionField];
-            }));
-          };
-        }
-      });
-    }
-  }
-
   private checkInputs(): boolean {
     const dataCount = Number(!!this.pagedData) + Number(!!this.data) +
       Number(!!(this.options && this.options.data));