Updating default make flags for make-settings in profiling section. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roshan Khatri <[email protected]>
hpatro
reviewed
Sep 9, 2024
Comment on lines
+48
to
+49
| and hotspots. This setup strikes a balance between maintaining a highly optimized executable | ||
| and ensuring that profiling and tracing tools provide accurate and actionable data. |
There was a problem hiding this comment.
Yeah :P for formatting the content better.
Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri
force-pushed
the
update-profiling-docs
branch
from
aa79c1c
to
86360ed
Compare
hpatro
approved these changes
Sep 9, 2024
madolson
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Valkey is now build with
OPTIMIZATION=-O3and-fno-omit-frame-pointer. The make setting in the valkey repository are updated here: https://github.com/valkey-io/valkey/blob/f504cf233bd08d56b1aa4af6c1ef3a2b4aa0ac60/src/Makefile#L32Docs did not seem to be updated for the same.
Updating the docs accordingly.