Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide about how to migrate from Redis #169

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

nastena1606
Copy link
Collaborator

@nastena1606 nastena1606 commented Sep 2, 2024

New topic page 'migration' about how to upgrade from Redis 7.2.5 for standalone and cluster.

Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good documents. I have mostly small changes for consistency and clarity.

Two other changes that are hard to remark in the review:

  1. You need to fix your DCO issues. I always find this link to be helpful on fixing the DCO issues.
  2. looks like you checked your pycache, that will need to be removed.

topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great document. I didn't review it completely. I just noticed some things I wanted to comment on. Feel free to ignore the comments though.

## Why to migrate to Valkey?

* Valkey is the vendor-neutral and open-source software
* Enhanced performance with multi-threading, dual-channel replication and I/O threading
Copy link
Contributor

@zuiderkwast zuiderkwast Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"multi-threading" and "I/O threading" is the same thing.

If you want to mention three things, can we mention improved memory efficiency instead?

Regarding memory efficiency, I'm thinking about two things, perhaps too complex to mention here but just FYI:

  1. the one-dict-per-slot in cluster mode (which also redis has, and had merged before we forked, but it's not included in any of the open source redis releases)
  2. embedded key in dict entry

topics/migration.md Outdated Show resolved Hide resolved
topics/migration.md Outdated Show resolved Hide resolved
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small rendering issues but otherwise LGTM.


a. Connect to Redis and check the number of keys:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should drop the triple-backtick fencing when nesting code blocks in two level deep lists.

As written, the site renders like this
Screenshot 2024-09-09 at 1 57 33 PM

But because you can indents are also interpreted as code blocks the it still works. When I remove 54 and 59 it looks like this rendered on-site:

Screenshot 2024-09-09 at 2 00 41 PM

(You'll also need to remove this for the other alphabetical code blocks.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was surprising. There's something odd about the indentation here but I believe it should be possible to use triple backticks inside list items too.

If I read https://spec.commonmark.org/0.31.2/#list-items correctly, I believe you should indent the body of list item 2. Make aligned under "M" in "Make" and align the body of a. Connect under the "C" in "Connect", rather than adding 4 spaces for each level.

Example:

2. Make a backup of your Redis instance. 

   a. Connect to Redis and check the number of keys:

      ```
      code block
      ```

or, if you want four spaces indentation per level, you can add an extra space between "2." and "Make" and between "a." and "Connect".

2.  Make a backup of your Redis instance. 

    a.  Connect to Redis and check the number of keys:

        ```
        code block
        ```

@nastena1606
Copy link
Collaborator Author

I have tried to fix the indentation. When I build it locally it looks good for me but I cannot figure out how it renders on the website unfortunately.

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in general. I don't have time to do a full review, sorry.

topics/migration.md Outdated Show resolved Hide resolved
Signed-off-by: Anastasia Alexadrova <[email protected]>
@zuiderkwast zuiderkwast changed the title Upgrade from Redis 7.2.5 for standalone and cluster Add guide about how to migrate from Redis Sep 22, 2024
@zuiderkwast zuiderkwast merged commit 00262ff into valkey-io:main Sep 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants