Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Cluster Info support #140

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mbaldessari
Copy link
Contributor

  • Try and extract some more info from the underlying cluster
  • Expose extra cluster info via helm variables
  • Added map initialization
  • Make sure we run this only when PlatformStatus is not nil

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaldessari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mbaldessari
Copy link
Contributor Author

Really not a fan of this approach tbh. If the number of entries in extraClusterInfo[] increase we're bound to have a lot of them in the list. And we'd also need to patch common/ for this. Plus by using a simple map[string]string struct we limit ourselves for things like lists of strings (baremetal has a few of those).
I think I want to punt this until there is an actual concrete need/user for this.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants